Skip to content

Add ids in architecture diagrams #6627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quilicicf opened this issue May 30, 2025 · 0 comments
Open

Add ids in architecture diagrams #6627

quilicicf opened this issue May 30, 2025 · 0 comments
Labels
Status: Triage Needs to be verified, categorized, etc

Comments

@quilicicf
Copy link

quilicicf commented May 30, 2025

Suggestion

Add ids to SVG elements in architecture diagrams to make it easier to style them.

Reason

My use case is animating the SVGs with Reveal.js fragments.

I can already do this with flowcharts since it's already done on this type of diagrams.

Exemple : making arrows appear one by one (tap ⬇ repeatedly to animate the graph on the right).

PoC

I've PoCed this in my fork, I can open a PR if you want to integrate the change.

I've only added ids to services and groups for now, we'd still need to :

  • Validate how ids should be built
  • Add ids to links/junctions

Note

To write tests for this feature, I had to run the renderer's draw method or battle with an army of mocks. I suggested an improvement in my work to use D3's test method using jsdom as a mock DOM instead of mocking D3.

I think it improves the tests greatly but it makes the PR a bit bulkier. I can split the work in two PRs, or only contribute the functional part (although it won't be tested then) as it suits you best.

@github-actions github-actions bot added the Status: Triage Needs to be verified, categorized, etc label May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc
Projects
None yet
Development

No branches or pull requests

1 participant